3 Commits

Author SHA1 Message Date
gary
7bd109b728 docs(qa): mark P1 issues 1-3 as resolved 2026-02-24 21:43:30 +01:00
gary
1a21bc18bb fix(flow): guard stepper and reset state on image-less project load 2026-02-24 21:43:28 +01:00
gary
fd72d53d2a feat(project): persist catalog snapshot in project data 2026-02-24 21:43:25 +01:00
5 changed files with 147 additions and 29 deletions

View File

@@ -2,7 +2,7 @@
Scope: Agentische, statische QA-Review (Flutter/Dart CLI lokal nicht verfügbar: `flutter` fehlt). Fokus auf 4-Step-Flow, Save/Load/Delete, JSON-Export und UX-Kantenfälle.
## Issue 1 (P1) 4-Step-Flow lässt Fortschritt ohne Pflichtdaten zu
## Issue 1 (P1) 4-Step-Flow lässt Fortschritt ohne Pflichtdaten zu ✅ ERLEDIGT (feat/mosaic-stepper-export)
**Bereich:** 4-Step-Flow
**Beobachtung**
@@ -27,7 +27,7 @@ Scope: Agentische, statische QA-Review (Flutter/Dart CLI lokal nicht verfügbar:
---
## Issue 2 (P1) Projekt-Load mit leerem Bild leert bestehenden Zustand nicht
## Issue 2 (P1) Projekt-Load mit leerem Bild leert bestehenden Zustand nicht ✅ ERLEDIGT (feat/mosaic-stepper-export)
**Bereich:** Save/Load-Flow
**Beobachtung**
@@ -49,7 +49,7 @@ Scope: Agentische, statische QA-Review (Flutter/Dart CLI lokal nicht verfügbar:
---
## Issue 3 (P1) Projekt-Snapshots sind nicht reproduzierbar, da Katalog nicht versioniert wird
## Issue 3 (P1) Projekt-Snapshots sind nicht reproduzierbar, da Katalog nicht versioniert wird ✅ ERLEDIGT (feat/mosaic-stepper-export)
**Bereich:** Save/Load-Flow + JSON-Export
**Beobachtung**

View File

@@ -205,6 +205,31 @@ class _MosaicHomePageState extends State<MosaicHomePage>
return File('${projectsDir.path}/latest_project.json');
}
bool get _hasSourceImage => _sourceImageBytes != null;
bool get _canGenerate => _hasSourceImage && !_isGenerating;
int get _maxAccessibleStepIndex =>
_hasSourceImage ? MosaicFlowStep.result.index : MosaicFlowStep.image.index;
List<MosaicPaletteSnapshotEntry> _catalogSnapshotFromCurrentCatalog() {
return _catalog
.map((entry) => MosaicPaletteSnapshotEntry(
name: entry.name,
colorValue: entry.colorValue,
))
.toList(growable: false);
}
void _showMissingImageHint() {
if (!mounted) return;
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(
content: Text('Bitte zuerst ein Bild auswählen.'),
),
);
}
MosaicProjectData _buildProjectData() {
return MosaicProjectData(
useCapSize: _useCapSize,
@@ -217,6 +242,7 @@ class _MosaicHomePageState extends State<MosaicHomePage>
colorVariation: _colorVariation,
selectedPreset: _selectedPreset.name,
sourceImageBytes: _sourceImageBytes,
catalogSnapshot: _catalogSnapshotFromCurrentCatalog(),
savedAt: DateTime.now(),
);
}
@@ -288,6 +314,7 @@ class _MosaicHomePageState extends State<MosaicHomePage>
final data = MosaicProjectData.fromJson(
jsonDecode(await file.readAsString()) as Map<String, dynamic>,
);
final hasCatalogSnapshot = data.catalogSnapshot.isNotEmpty;
if (!mounted) return;
setState(() {
@@ -305,18 +332,22 @@ class _MosaicHomePageState extends State<MosaicHomePage>
orElse: () => StylePreset.ausgewogen,
);
if (data.sourceImageBytes != null) {
_sourceImageBytes = data.sourceImageBytes;
_result = null;
_currentFlowStep = MosaicFlowStep.result;
}
_currentFlowStep =
_sourceImageBytes == null ? MosaicFlowStep.image : MosaicFlowStep.result;
_activeSection = HomeSection.mosaic;
});
if (data.sourceImageBytes != null) await _generate();
if (data.sourceImageBytes != null) {
await _generate(catalogSnapshotOverride: hasCatalogSnapshot ? data.catalogSnapshot : null);
}
if (!silent && mounted) {
final message = hasCatalogSnapshot
? 'Projekt geladen ✅ (mit gespeichertem Katalog-Snapshot)'
: 'Projekt geladen ✅ (ohne Snapshot: aktueller Katalog aktiv)';
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text('Projekt geladen ✅')),
SnackBar(content: Text(message)),
);
}
} catch (_) {
@@ -879,8 +910,24 @@ class _MosaicHomePageState extends State<MosaicHomePage>
_scheduleRegenerate();
}
Future<void> _generate() async {
if (_sourceImageBytes == null || _catalog.isEmpty) return;
Future<void> _generate({List<MosaicPaletteSnapshotEntry>? catalogSnapshotOverride}) async {
if (_sourceImageBytes == null) {
_showMissingImageHint();
return;
}
final paletteSource = catalogSnapshotOverride != null && catalogSnapshotOverride.isNotEmpty
? catalogSnapshotOverride
.map((entry) => <String, dynamic>{
'name': entry.name,
'value': entry.colorValue,
})
.toList(growable: false)
: _catalog
.map((p) => <String, dynamic>{'name': p.name, 'value': p.colorValue})
.toList(growable: false);
if (paletteSource.isEmpty) return;
final int gridW = math.max(1, int.tryParse(_gridWidthCtrl.text) ?? 40);
final int gridH = math.max(1, int.tryParse(_gridHeightCtrl.text) ?? 30);
@@ -899,9 +946,7 @@ class _MosaicHomePageState extends State<MosaicHomePage>
'ditheringStrength': _ditheringStrength,
'edgeEmphasis': _edgeEmphasis,
'colorVariation': _colorVariation,
'palette': _catalog
.map((p) => <String, dynamic>{'name': p.name, 'value': p.colorValue})
.toList(growable: false),
'palette': paletteSource,
};
final out = await compute(_generateMosaicIsolate, payload);
@@ -952,7 +997,7 @@ class _MosaicHomePageState extends State<MosaicHomePage>
? FloatingActionButton.extended(
backgroundColor: Colors.white.withValues(alpha: 0.85),
foregroundColor: Theme.of(context).colorScheme.primary,
onPressed: _isGenerating ? null : _generate,
onPressed: _canGenerate ? _generate : null,
icon: _isGenerating
? const SizedBox(
width: 18,
@@ -1085,8 +1130,12 @@ class _MosaicHomePageState extends State<MosaicHomePage>
);
},
onStepContinue: () {
setState(() {
final next = _currentFlowStep.index + 1;
if (next > _maxAccessibleStepIndex) {
_showMissingImageHint();
return;
}
setState(() {
if (next <= MosaicFlowStep.result.index) {
_currentFlowStep = MosaicFlowStep.values[next];
}
@@ -1101,6 +1150,10 @@ class _MosaicHomePageState extends State<MosaicHomePage>
});
},
onStepTapped: (index) {
if (index > _maxAccessibleStepIndex) {
_showMissingImageHint();
return;
}
setState(() => _currentFlowStep = MosaicFlowStep.values[index]);
},
steps: [
@@ -1250,7 +1303,7 @@ class _MosaicHomePageState extends State<MosaicHomePage>
children: [
FilledButton.icon(
key: const Key('generate-btn'),
onPressed: _isGenerating ? null : _generate,
onPressed: _canGenerate ? _generate : null,
icon: const Icon(Icons.auto_fix_high_rounded),
label: const Text('Generate Mosaic'),
),

View File

@@ -1,6 +1,28 @@
import 'dart:convert';
import 'dart:typed_data';
class MosaicPaletteSnapshotEntry {
final String name;
final int colorValue;
const MosaicPaletteSnapshotEntry({
required this.name,
required this.colorValue,
});
Map<String, dynamic> toJson() => {
'name': name,
'colorValue': colorValue,
};
factory MosaicPaletteSnapshotEntry.fromJson(Map<String, dynamic> json) {
return MosaicPaletteSnapshotEntry(
name: json['name'] as String? ?? 'Unbenannt',
colorValue: (json['colorValue'] as num?)?.toInt() ?? 0xFF000000,
);
}
}
class MosaicProjectData {
final bool useCapSize;
final String gridWidth;
@@ -12,6 +34,7 @@ class MosaicProjectData {
final double colorVariation;
final String selectedPreset;
final Uint8List? sourceImageBytes;
final List<MosaicPaletteSnapshotEntry> catalogSnapshot;
final DateTime savedAt;
const MosaicProjectData({
@@ -25,6 +48,7 @@ class MosaicProjectData {
required this.colorVariation,
required this.selectedPreset,
required this.sourceImageBytes,
required this.catalogSnapshot,
required this.savedAt,
});
@@ -40,23 +64,32 @@ class MosaicProjectData {
'selectedPreset': selectedPreset,
'sourceImageBase64':
sourceImageBytes == null ? null : base64Encode(sourceImageBytes!),
'catalogSnapshot': catalogSnapshot.map((entry) => entry.toJson()).toList(),
'savedAt': savedAt.toIso8601String(),
};
factory MosaicProjectData.fromJson(Map<String, dynamic> json) {
final sourceB64 = json['sourceImageBase64'] as String?;
final snapshotRaw = (json['catalogSnapshot'] as List?) ?? const [];
return MosaicProjectData(
useCapSize: json['useCapSize'] as bool? ?? false,
gridWidth: json['gridWidth'] as String? ?? '40',
gridHeight: json['gridHeight'] as String? ?? '30',
capSize: json['capSize'] as String? ?? '12',
fidelityStructure: (json['fidelityStructure'] as num?)?.toDouble() ?? 0.5,
ditheringStrength: (json['ditheringStrength'] as num?)?.toDouble() ?? 0.35,
ditheringStrength:
(json['ditheringStrength'] as num?)?.toDouble() ?? 0.35,
edgeEmphasis: (json['edgeEmphasis'] as num?)?.toDouble() ?? 0.4,
colorVariation: (json['colorVariation'] as num?)?.toDouble() ?? 0.3,
selectedPreset: json['selectedPreset'] as String? ?? 'ausgewogen',
sourceImageBytes: sourceB64 == null ? null : base64Decode(sourceB64),
savedAt: DateTime.tryParse(json['savedAt'] as String? ?? '') ?? DateTime.now(),
catalogSnapshot: snapshotRaw
.whereType<Map>()
.map((entry) => MosaicPaletteSnapshotEntry.fromJson(
Map<String, dynamic>.from(entry)))
.toList(growable: false),
savedAt:
DateTime.tryParse(json['savedAt'] as String? ?? '') ?? DateTime.now(),
);
}
}

View File

@@ -4,7 +4,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:korken_mosaic/project_codec.dart';
void main() {
test('MosaicProjectData json roundtrip keeps values', () {
test('MosaicProjectData json roundtrip keeps values including catalog snapshot', () {
final original = MosaicProjectData(
useCapSize: true,
gridWidth: '50',
@@ -16,6 +16,10 @@ void main() {
colorVariation: 0.5,
selectedPreset: 'realistisch',
sourceImageBytes: Uint8List.fromList([1, 2, 3]),
catalogSnapshot: const [
MosaicPaletteSnapshotEntry(name: 'White', colorValue: 0xFFF2F2F2),
MosaicPaletteSnapshotEntry(name: 'Blue', colorValue: 0xFF3F6FD8),
],
savedAt: DateTime.parse('2026-01-01T12:00:00Z'),
);
@@ -28,5 +32,22 @@ void main() {
expect(decoded.selectedPreset, 'realistisch');
expect(decoded.sourceImageBytes, isNotNull);
expect(decoded.sourceImageBytes!, [1, 2, 3]);
expect(decoded.catalogSnapshot.length, 2);
expect(decoded.catalogSnapshot.first.name, 'White');
expect(decoded.catalogSnapshot.last.colorValue, 0xFF3F6FD8);
});
test('MosaicProjectData defaults to empty snapshot when old project has none', () {
final decoded = MosaicProjectData.fromJson({
'useCapSize': false,
'gridWidth': '40',
'gridHeight': '30',
'capSize': '12',
'selectedPreset': 'ausgewogen',
'savedAt': '2026-01-01T12:00:00Z',
});
expect(decoded.catalogSnapshot, isEmpty);
expect(decoded.sourceImageBytes, isNull);
});
}

View File

@@ -1,8 +1,9 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:korken_mosaic/main.dart';
void main() {
testWidgets('shows 4-step workflow and can navigate to result step',
testWidgets('stepper blocks forward navigation without image and shows hint',
(WidgetTester tester) async {
await tester.pumpWidget(const KorkenMosaicApp());
@@ -12,13 +13,23 @@ void main() {
expect(find.text('4) Ergebnis'), findsOneWidget);
await tester.tap(find.text('Weiter'));
await tester.pumpAndSettle();
await tester.tap(find.text('Weiter'));
await tester.pumpAndSettle();
await tester.tap(find.text('Weiter'));
await tester.pumpAndSettle();
await tester.pump();
expect(find.byKey(const Key('generate-btn')), findsOneWidget);
expect(find.text('Export JSON'), findsOneWidget);
// Stays on step 1 because no source image is available yet.
expect(find.text('Import target image'), findsOneWidget);
expect(find.text('Bitte zuerst ein Bild auswählen.'), findsOneWidget);
});
testWidgets('generate actions are disabled without image',
(WidgetTester tester) async {
await tester.pumpWidget(const KorkenMosaicApp());
final fab = tester.widget<FloatingActionButton>(
find.byType(FloatingActionButton),
);
expect(fab.onPressed, isNull);
// Result-step action is not reachable before image selection.
expect(find.byKey(const Key('generate-btn')), findsNothing);
});
}