Yadciel/taskcafe
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: emoji remark plugin sets children type to html instead of parent

Browse Source 
This fixes the issue where if a URL was added to the comment, the remark
plugin would break. Instead of changing the parent node to be html, it
now sets any 'text' type children to be 'html' instead.
This commit is contained in:
Jordan Knott 2021-01-04 16:09:14 -06:00
parent f215418be1
commit 77087158a9
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/shared/components/TaskDetails/Styles.ts
View File

@ -653,7 +653,7 @@ export const ActivityItemComment = styled.div<{ editable: boolean }>`
${props => props.editable && 'width: 100%;'} ${props => props.editable && 'width: 100%;'}
& span { & span {
display: flex; display: inline-flex;
align-items: center; align-items: center;
} }
& ul { & ul {

13
frontend/src/shared/components/TaskDetails/remark.js
View File

@ -44,9 +44,16 @@ function plugin(options) {
visit(tree, 'paragraph', function(node) { visit(tree, 'paragraph', function(node) {
console.log(tree); console.log(tree);
// node.value = node.value.replace(RE_EMOJI, getEmoji); // node.value = node.value.replace(RE_EMOJI, getEmoji);
node.type = 'html'; // jnode.type = 'html';
node.tagName = 'div'; // jnode.tagName = 'div';
node.value = node.children[0].value.replace(RE_EMOJI, getEmoji); // jnode.value = '';
for (let nodeIdx = 0; nodeIdx < node.children.length; nodeIdx++) {
if (node.children[nodeIdx].type === 'text') {
node.children[nodeIdx].type = 'html';
node.children[nodeIdx].tagName = 'div';
node.children[nodeIdx].value = node.children[nodeIdx].value.replace(RE_EMOJI, getEmoji);
}
}
if (emoticonEnable) { if (emoticonEnable) {
// node.value = node.value.replace(RE_SHORT, getEmojiByShortCode); // node.value = node.value.replace(RE_SHORT, getEmojiByShortCode);