Only db commit on requests that change the database

This commit is contained in:
Jeremy Zhang
2018-06-15 00:13:09 +00:00
parent 4c41a31418
commit d540a4888b
5 changed files with 33 additions and 5 deletions

View File

@ -165,6 +165,7 @@ def edit_custom_css_post(css_id):
dbcss.css = css
dbcss.css_variables = variables
dbcss.css_var_bool = variables_enabled
db.session.commit()
return jsonify({"id": dbcss.id})
@user.route("/custom_css/edit/<css_id>", methods=["DELETE"])
@ -179,6 +180,7 @@ def edit_custom_css_delete(css_id):
if dbcss.user_id != session['user_id']:
abort(403)
db.session.delete(dbcss)
db.session.commit()
return jsonify({})
@user.route("/administrate_guild/<guild_id>", methods=["GET"])
@ -252,6 +254,7 @@ def update_administrate_guild(guild_id):
guest_icon = None
db_guild.guest_icon = guest_icon
db.session.commit()
emit("guest_icon_change", {"guest_icon": guest_icon if guest_icon else url_for('static', filename='img/titanembeds_square.png')}, room="GUILD_"+guild_id, namespace="/gateway")
return jsonify(
guild_id=db_guild.guild_id,
@ -339,6 +342,7 @@ def ban_unauthenticated_user():
db.session.delete(db_ban)
db_ban = UnauthenticatedBans(guild_id, db_user.ip_address, db_user.username, db_user.discriminator, reason, session["user_id"])
db.session.add(db_ban)
db.session.commit()
return ('', 204)
@user.route("/ban", methods=["DELETE"])
@ -361,6 +365,7 @@ def unban_unauthenticated_user():
if db_ban.lifter_id is not None:
abort(409)
db_ban.liftBan(session["user_id"])
db.session.commit()
return ('', 204)
@user.route("/revoke", methods=["POST"])
@ -380,6 +385,7 @@ def revoke_unauthenticated_user():
if db_user.isRevoked():
abort(409)
db_user.revokeUser()
db.session.commit()
return ('', 204)
@user.route('/donate', methods=["GET"])
@ -440,6 +446,7 @@ def donate_confirm():
set_titan_token(session["user_id"], tokens, action)
session["tokens"] = get_titan_token(session["user_id"])
add_badge(session["user_id"], "supporter")
db.session.commit()
return redirect(url_for('user.donate_thanks', transaction=trans_id))
else:
return redirect(url_for('index'))
@ -482,6 +489,7 @@ def donate_patch():
entry = Cosmetics(session["user_id"])
entry.guest_icon = True
db.session.add(entry)
db.session.commit()
return ('', 204)
@user.route("/patreon")
@ -564,6 +572,7 @@ def patreon_sync_post():
set_titan_token(session["user_id"], usr["titan"]["eligible_tokens"], "PATREON {} [{}]".format(usr["attributes"]["full_name"], usr["id"]))
add_badge(session["user_id"], "supporter")
session["tokens"] = get_titan_token(session["user_id"])
db.session.commit()
return ('', 204)
@user.route("/patreon/thanks")